Remove code 1002 CannotCreateRoom - #967
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #967 +/- ##
==========================================
+ Coverage 99.16% 99.19% +0.02%
==========================================
Files 189 189
Lines 6704 6704
Branches 1024 1024
==========================================
+ Hits 6648 6650 +2
+ Misses 42 41 -1
+ Partials 14 13 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Closes #821
There are only 2 codes in the 100x region: 1001 CannotConnect, and 1003 CannotJoinRoom.
According to the Nicotine+ docs this code has only been observed being sent when attempting to join/create a private room that already exists.
I'm going to leave this named
CannotJoinRoom, which covers both the (hypothetical) join and create scenarios, as you must join a room to create it. And the work is already done and tested.