Skip to content

Remove code 1002 CannotCreateRoom - #967

Merged
jpdillingham merged 1 commit into
masterfrom
code-1002
Sep 1, 2026
Merged

Remove code 1002 CannotCreateRoom#967
jpdillingham merged 1 commit into
masterfrom
code-1002

Conversation

@jpdillingham

Copy link
Copy Markdown
Owner

Closes #821

There are only 2 codes in the 100x region: 1001 CannotConnect, and 1003 CannotJoinRoom.

According to the Nicotine+ docs this code has only been observed being sent when attempting to join/create a private room that already exists.

I'm going to leave this named CannotJoinRoom, which covers both the (hypothetical) join and create scenarios, as you must join a room to create it. And the work is already done and tested.

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.19%. Comparing base (8e260ea) to head (15facc4).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #967      +/-   ##
==========================================
+ Coverage   99.16%   99.19%   +0.02%     
==========================================
  Files         189      189              
  Lines        6704     6704              
  Branches     1024     1024              
==========================================
+ Hits         6648     6650       +2     
+ Misses         42       41       -1     
+ Partials       14       13       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jpdillingham
jpdillingham merged commit d22818f into master Sep 1, 2026
5 checks passed
@jpdillingham
jpdillingham deleted the code-1002 branch September 1, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement server code 1003/'CantCreateRoom'

1 participant