Skip to content

Add new undocumented option ReportUnreadMessageData to emit a diagnostic warning if data is left unread - #970

Merged
jpdillingham merged 8 commits into
masterfrom
reader-warning
Sep 5, 2026
Merged

Add new undocumented option ReportUnreadMessageData to emit a diagnostic warning if data is left unread#970
jpdillingham merged 8 commits into
masterfrom
reader-warning

Conversation

@jpdillingham

Copy link
Copy Markdown
Owner

I discovered through #968 that a message had the potential to contain additional data, but the code wasn't reading it. I've run into this before and it has been in the back of my mind that I might be discarding data from incoming messages unknowingly.

This PR adds an undocumented ReportUnreadMessageData public static property to SoulseekClient that when set to true will cause every message to check whether there is unread data after parsing and if so, emit a diagnostic warning. This setting can be turned on or off at any time after the SoulseekClient class has been instantiated.

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.20%. Comparing base (d22818f) to head (cddbf13).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #970      +/-   ##
==========================================
+ Coverage   99.19%   99.20%   +0.01%     
==========================================
  Files         189      189              
  Lines        6707     6829     +122     
  Branches     1026     1085      +59     
==========================================
+ Hits         6653     6775     +122     
  Misses         41       41              
  Partials       13       13              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud

sonarqubecloud Bot commented Sep 5, 2026

Copy link
Copy Markdown

@jpdillingham
jpdillingham merged commit 9839b29 into master Sep 5, 2026
5 checks passed
@jpdillingham
jpdillingham deleted the reader-warning branch September 5, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant