Enhance to work with custom css-tags#33
Open
digital-h wants to merge 1 commit into
Open
Conversation
…ough tag-attributes.
Owner
|
Another alternative can be overwrite the properties files in your own project. If do you place your custom properties files on src/main/resources/thymeleaf-spring-data-dialect/*.properties on project that uses the library, this will be used |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I pretty much like your library. But unfortunately I ran into the problem, that I already have a style for my pagination with my dedicated css-classes. Therefor I needed a way to customize your output to match my css-classes.
I now came up with the following apprach, as I think it is most straightforward to handle it directly in the tag. The idea is: if a custom-css-tag is defined, then use it. Otherwise do the fallback to the default css-class.
I hope you like my approach and I would be glad if you would include it in your project, so that I can also work with future releases.
Hint: I only refactored the properties-file for german now. In case you want to merge this PR, these changes have to be adapted to the other languages as well.
Hope to hear from you soon!