-
Notifications
You must be signed in to change notification settings - Fork 0
Implement Composer #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
e75994e
713188a
7219868
4a4e79f
2005d5e
5d2fb8d
0a8a67b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| root = true | ||
|
|
||
| [*] | ||
| charset = utf-8 | ||
| end_of_line = lf | ||
| insert_final_newline = true | ||
| trim_trailing_whitespace = true | ||
|
|
||
| [*.php] | ||
| indent_style = space | ||
| indent_size = 2 | ||
|
|
||
| [*.{js,jsx,ts,tsx,json,css,scss}] | ||
| indent_style = space | ||
| indent_size = 2 | ||
|
|
||
| [*.xml] | ||
| indent_style = space | ||
| indent_size = 2 | ||
|
|
||
| [*.md] | ||
| trim_trailing_whitespace = false | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| name: Lint | ||
|
|
||
| on: | ||
| push: | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| lint: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup PHP | ||
| uses: shivammathur/setup-php@v2 | ||
| with: | ||
| php-version: '8.2' | ||
| coverage: none | ||
|
|
||
| - name: Get Composer Cache Directory | ||
| id: composer-cache | ||
| run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT | ||
|
|
||
| - name: Cache Composer dependencies | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: ${{ steps.composer-cache.outputs.dir }} | ||
| key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }} | ||
| restore-keys: ${{ runner.os }}-composer- | ||
|
|
||
| - name: Install Composer dependencies | ||
| run: composer install --prefer-dist --no-progress | ||
|
Comment on lines
+28
to
+32
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add Two related CI reliability issues:
🔧 Proposed fix- run: composer install --prefer-dist --no-progress
+ run: composer install --prefer-dist --no-progress --no-interaction🤖 Prompt for AI Agents |
||
|
|
||
| - name: Run composer lint | ||
| run: composer lint | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,10 @@ | ||||||
| { | ||||||
| "[php]": { | ||||||
| "editor.defaultFormatter": "ValeryanM.vscode-phpsab", | ||||||
| "editor.formatOnSave": true | ||||||
| }, | ||||||
| "phpsab.executablePathCBF": "./vendor/bin/phpcbf", | ||||||
| "phpsab.executablePathCS": "./vendor/bin/phpcs", | ||||||
| "phpsab.standard": "PSR12", | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
While 🔧 Proposed fix- "phpsab.standard": "PSR12",
+ "phpsab.standard": "WordPress",📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| "phpsab.autoRulesetSearch": true | ||||||
| } | ||||||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
# Find and examine phpcs.xml fd phpcs.xml --exec cat {}Repository: jpjuliao/multi-step-form-builder
Length of output: 1217
🏁 Script executed:
Repository: jpjuliao/multi-step-form-builder
Length of output: 85
🏁 Script executed:
# Get context on .editorconfig file itself cat -n .editorconfigRepository: jpjuliao/multi-step-form-builder
Length of output: 544
PHP indentation in
.editorconfigconflicts with WordPress Coding Standards — CI lint will fail.phpcs.xmluses WordPress Coding Standards, which mandate tab indentation for PHP files. However,.editorconfigspecifies 2-space indentation for PHP. Any code written by contributors following the editor config will failcomposer lintin CI.Change PHP indentation in
.editorconfigto tabs:🔧 Fix
📝 Committable suggestion
🤖 Prompt for AI Agents