Conversation
Owner
jpmcb
commented
Aug 20, 2023
jpmcb
commented
Signed-off-by: John McBride <jpmmcbride@gmail.com>
This was referenced Sep 15, 2023
Open
* Refactor: Bring everything up to speed with new deps and node 20 * Based on works of John McBride (@jpmcb) * Update dependencies: + Bump: + @typescript-eslint/eslint-plugin: ^6.7.0 + @typescript-eslint/parser: ^6.7.0 + eslint: ^8.49.0 + typescript: ^5.2.2 + Add: + eslint-import-resolver-typescript: ^3.6.0 Required for eslint to work with typescript import resolver + msw: ^1.3.1 Introduced to replace nock + Replace deprecated: + Replace @zeit/ncc with @vercel/ncc, upstream suggestion Build error: digital envelope routines::unsupported + Drop: + nock due to the issue [1] related to the fetch experimental feature of nodejs * Refactor code: + TypeScript compile errors + ESLint errors and warnings + Tests reimplement GitHub API responses mockup using msw/node instead of nock * Declare the action runs using node20 --- [1] nock/nock#2397 Signed-off-by: Neutron Soutmun <neutron.s@linecorp.com> * chore: cosmetic apply with prettier Signed-off-by: Neutron Soutmun <neutron.s@linecorp.com> --------- Signed-off-by: Neutron Soutmun <neutron.s@linecorp.com>
Signed-off-by: John McBirde <jpmmcbride@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.