You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey, added a basic device definition for the GL520M and I believe this should fix compilation issues using modern GCC. I've not touched C in a while and these fixes were just based off my best guesses/intuition. I haven't noticed any unexpected behaviour but I'm only using the GL520M right now.
Do you have the protocol description for the GL520M available?
I guess the definition is not correct at the end where you skip numbers. Please check if “sent” timestamp is decoded correctly for all the different messages
we decided to fix the compilation error by changing the function declaration rather than the function definition similar to what was done in the original mongoose repo
you added compilation instructions and Makefile changes for Darwin are much appreciated, we will incorporate them
changes to the device definitions we can only merge if you share the protocol description (e.g. GV520 @track Air Interface Protocol V1.01.pdf) with us via direct message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, added a basic device definition for the GL520M and I believe this should fix compilation issues using modern GCC. I've not touched C in a while and these fixes were just based off my best guesses/intuition. I haven't noticed any unexpected behaviour but I'm only using the GL520M right now.Should fix issue #20PR updated to only include changes made to
devices.ymlfor the definitions