This repository was archived by the owner on Apr 10, 2019. It is now read-only.
Fix mvn build compile protobuf error - #3
Open
lgrcyanny wants to merge 1 commit into
Open
Conversation
Author
|
@vruusmann please review the patch, thank you. And I found that tensorflow support is not complete yet, such as it doesn't support KMeans, RNN, SVM etc. are there any plans to support more tensorflow estimators? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1. Fix mvn build error
build the master branch, I got many errors as follows:
jpmml-tensorflow/target/generated-sources/protobuf/java/org/tensorflow/framework/TensorProto.java:[63,18] Can't Find Symbol
2. Fix a compile error in jpmml-tensorflow/src/main/java/org/jpmml/tensorflow/SavedModel.java
The error is
/Users/lgrcyanny/Codecookies/machine-learning-workspace/pmml-wp/jpmml-tensorflow/src/main/java/org/jpmml/tensorflow/SavedModel.java:[136,50] incompatiable with: java.util.List<org.tensorflow.Tensor<?>> can't transformed to java.util.List<org.tensorflow.Tensor>
The reason is tensorflow latest API is 1.4
How was this patch tested?
build on my local MAC machine and success