Repository navigation
Component names no longer repeat their version in generated headers (H6) - #702
Merged
Merged
Conversation
Component names that repeated their version are renamed in five guides; bundles rebuilt.
Deploying secureconfig with
|
| Latest commit: |
daf6cc4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ace416e7.secureconfig.pages.dev |
| Branch Preview URL: | https://fix-header-name-versions.secureconfig.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carried QA note H6 (from the #697 review): some version-basis component names already contained the version that the generated header appends, so headers in
host.md,gitops-controllers.md,mfa.mdandself-signed.mdstated those versions twice (for DNF, cloud-init, Dex, Redis, MySQL and RFC 9525), and BusyBox, named "BusyBox 1.36.1" with basis1_36_1, did the same in the summary lists ofhost.mdanddeployment-lifecycle.md.Change
Only component
namevalues change, in five guides; the generated summary and header are regenerated by the current renderer.host.md: DNF, cloud-init (26.2 and 20.1), BusyBox. The header now combines the two cloud-init bases into one entry ("cloud-init 26.2 and 20.1"), so BusyBox 1_36_1 is shown and "plus 1 more recorded basis" is gone.gitops-controllers.md: Dex source, Redis source.mfa.md: MySQL multifactor authentication (8.0 and 8.4), MySQL WebAuthn authentication. The header combines the two multifactor bases into one entry ("MySQL multifactor authentication 8.0 and 8.4"), reducing "plus 10 more recorded bases" to "plus 9 more".self-signed.md: Service identity (basis RFC 9525).deployment-lifecycle.md: BusyBox. That component is outside the header's eight entries, so only the summary list changes.No basis, source, key, claim, body text or
body_sha256changes. CHANGELOG, VERSION 1.0.702, plugin.json and both bundles are updated.Checks
tools/run_all_checks.shwith the pinned parser first on PATH;version_basis.py --checkpasses for all 100 guides.