Repository navigation
docker.md: cite runtime secret delivery and the .env exclusion from Git (TODO 1.296) - #703
Merged
Merged
Conversation
…it (TODO 1.296) Docker Compose and Swarm secrets, container environment, env_file and .env interpolation pages pinned at 4e9a5751; Git v2.49.0 gitignore reused; advice and assessment labelled; release 1.0.703.
Deploying secureconfig with
|
| Latest commit: |
7024222
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dc540b93.secureconfig.pages.dev |
| Branch Preview URL: | https://content-docker-secrets-296.secureconfig.pages.dev |
…ty, bullet and DONE wording, TODO 1.314 follow-up)
…ds the new row (QA round 2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO 1.296:
docker.md's secrets rule had no source for its runtime secret-delivery methods or for keeping.envout of Git.Change
env_filesection; describes Compose secrets (a file under/run/secrets/, Linux containers only, granted per service) and Swarm secrets (swarm services only, encrypted in transit and at rest, with an in-memory mount in Linux containers). As this guide's reasoning, defining a value in.envdoes not by itself set the container's environment: the cited examples pass values through anenvironmententry or load an environment file through anenv_fileentry, while interpolation can also place values elsewhere in the Compose file. Offering environment files, and their weaker standing, are labelled as this guide's advice and assessment..envbullet: keeping.envin.gitignore, and untracking it if already tracked, is labelled as this guide's advice, citing the Git v2.49.0 gitignore lines already in the guide (matching untracked files are ignored; tracked files are not affected).docker-secretscomponent with eight ranges in the pinned Docker docs commit 4e9a5751 (Compose secrets, container environment,env_file, interpolation into the Compose file,.envinterpolation, Swarm secrets).secretsclaim now names these sources and drops its "no direct source" sentence; the history caveat stays. The claim is 411 characters, keeping the body's qualifiers and labels.workloadfollow-up (label keeping.envin.gitignoreas advice, add untracking, consider advising rotation of any secret ever committed). The header and summary are regenerated; CHANGELOG, VERSION 1.0.703, plugin.json and both bundles are updated.Not changed: the
workloadclaim (now TODO 1.314); any Verify step or command.Checks
tools/run_all_checks.shwith the pinned parser first on PATH: all gates passed.