Conversation
Moving a file to a name that differs only in Unicode normalization form (NFC vs NFD) throws "Source and destination must not be the same." on filesystems that auto-normalize, such as APFS, even though the source and destination are visually identical and the user is just renaming the file. This mirrors the case-insensitive rename bug fixed in #801, so it gets the same fix: when the basenames differ but resolve to the same inode, and they're equal after either lowercasing or NFC normalization, treat it as a rename instead of raising the same-path error. Fixes #859
Collaborator
Author
|
Changes pushed to #1079 |
RyanZim
deleted the
ryan/afonsojanu-fix/move-unicode-normalization-paths/tests
branch
September 17, 2026 15:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.