Skip to content

[dbapi2] fix unknown refs#1342

Open
marscher wants to merge 1 commit intojpype-project:masterfrom
marscher:fix_dbapi2_undefined_refs
Open

[dbapi2] fix unknown refs#1342
marscher wants to merge 1 commit intojpype-project:masterfrom
marscher:fix_dbapi2_undefined_refs

Conversation

@marscher
Copy link
Member

@marscher marscher commented Feb 5, 2026

fixes #1241

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.48%. Comparing base (f82ca24) to head (cf64f9b).

Files with missing lines Patch % Lines
jpype/dbapi2.py 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1342      +/-   ##
==========================================
- Coverage   86.48%   86.48%   -0.01%     
==========================================
  Files         113      113              
  Lines       10513    10512       -1     
  Branches     4029     4029              
==========================================
- Hits         9092     9091       -1     
  Misses        822      822              
  Partials      599      599              
Files with missing lines Coverage Δ
jpype/dbapi2.py 94.34% <83.33%> (-0.01%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marscher
Copy link
Member Author

marscher commented Feb 5, 2026

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage.

yeah, that's why it slipped our test suite in the first place. That code path was causing an exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dbapi2 undefined references

1 participant