Fix phantom change event when initial HOT has 0 rows#373
Open
ericnewkirk wants to merge 13 commits intojrowen:masterfrom
Open
Fix phantom change event when initial HOT has 0 rows#373ericnewkirk wants to merge 13 commits intojrowen:masterfrom
ericnewkirk wants to merge 13 commits intojrowen:masterfrom
Conversation
avoid intermittent error calling JS()
Avoid firing change event when defaults are null Change event will still fire if defaults are provided
Onchange fix
Change test for reporting changes to R server
Onchange fix
Somehow one fix was nixed by the other This commit contains both: Fix phantom change event with 0 rows Fix minsparerows glitch
Combine fixes
Fix for minsparerows is stuck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
!==to!=in testing old and new values so changes fromundefinedtonullwon't be passed to R.