Skip to content

replace as.character with format for R4.3#431

Open
klin333 wants to merge 1 commit intojrowen:masterfrom
klin333:replace_as.character
Open

replace as.character with format for R4.3#431
klin333 wants to merge 1 commit intojrowen:masterfrom
klin333:replace_as.character

Conversation

@klin333
Copy link
Copy Markdown

@klin333 klin333 commented Nov 13, 2023

in R4.3 the following could give warning:

rhandsontable::rhandsontable(data.frame(x = Sys.Date()))
# Warning message:
# In as.character.POSIXt(as.POSIXlt(x), ...) :
#   as.character(td, ..) no longer obeys a 'format' argument; use format(td, ..) ?

This pull request fixes it

@petersmp
Copy link
Copy Markdown

I am also running into this issue. It looks like this PR would fix the issue.

@J-flem
Copy link
Copy Markdown

J-flem commented Jul 30, 2024

Thank you for this branch @klin333. Hopefully it can be pulled into the main branch soon

@jjjpellinen
Copy link
Copy Markdown

Ran into this issue a year ago #427.

This will fix it. And somehow it seems surprisingly time consuming to merge these 2 lines.

@shradha-singh
Copy link
Copy Markdown

Can someone help review and approve this? I am also running into this issue with an R version upgrade.

@ropersam
Copy link
Copy Markdown

Also running into this issue after upgrade within my organisation. Praying for approval 🙏

@adrianbeer
Copy link
Copy Markdown

Same here, seems like this repo isn't being maintained anymore unfortunately...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants