Skip to content

motion: raise the rule time budget from 5 to 30 seconds (fixes #76) - #78

Merged
jrpool merged 1 commit into
jrpool:mainfrom
wittjeff:fix/motion-timeout
Aug 19, 2026
Merged

motion: raise the rule time budget from 5 to 30 seconds (fixes #76)#78
jrpool merged 1 commit into
jrpool:mainfrom
wittjeff:fix/motion-timeout

Conversation

@wittjeff

Copy link
Copy Markdown
Collaborator

Remedy 1 from #76: raises the motion rule's timeOut from 5 to 30 seconds (matching the existing allCaps budget), with a comment recording why the budget needs the room.

Verification

Full job on a 150-section local page (chromium, 1280×800, imageColor: 2, rules: ['y', 'motion']):

One further observation for #76's longer-term remedies

While testing on a very tall gradient-heavy page (400 sections), the failure moved upstream: the catalog's own page image failed at shoot()'s internal page.screenshot 4-second allowance ("Screenshot failed: Timeout 4000ms exceeded"), so images[0] never existed and motion was prevented with "Initial image missing". So the 4-second screenshot allowance bounds not just motion's shot but the existence of the baseline itself on tall pages — worth folding into any follow-up on #76's remedy 2.

🤖 Generated with Claude Code

)

The budget must cover a full-page screenshot (itself allowed 4 seconds
in procs/shoot.js), decoding two full-page PNGs, and a pixelmatch
comparison. With 5 seconds, the rule timed out whenever an initial
image existed; in a production fleet, 4 of 4 image-bearing scans were
prevented by timeout and the rule never completed a comparison.

Verified with a full job on a 150-section local page (chromium,
1280x800, imageColor 2, rules ['y', 'motion']): the rule now completes
in 7 seconds with a correct no-motion verdict - over the old budget on
even this moderate page, comfortably within the new one. 30 matches the
existing budget of the allCaps rule.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@jrpool jrpool left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for discovering pages that time out and proposing a solution for the motion rule, @wittjeff.

@jrpool
jrpool merged commit 814a458 into jrpool:main Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants