Reject letter input without row number#38
Merged
jserv merged 1 commit intojserv:mainfrom Mar 11, 2025
Merged
Conversation
jserv
requested changes
Mar 11, 2025
Owner
jserv
left a comment
There was a problem hiding this comment.
Instead of "trailing number," use "row numbers" for precise naming.
Owner
|
The term "row numbers" is clearer and more standard, ensuring that the input includes both the row (number) and the column (alphabet). |
Contributor
Author
|
Thanks for your feedback! "row numbers" sounds clearer, but since only one row number is entered at a time, should it be singular ("row number") instead? |
Owner
The term "row numbers" means the collection of the numbers in row, and you should use the form "row number" for each input. |
This patch improves input validation by ensuring that a letter input must be followed by a row number. If the user enters only a letter within the valid board range without a corresponding row number, an error message is displayed. This enhances clarity and prevents invalid moves, ensuring correct input handling. Co-authored-by: charliechiou <charlie910417@gmail.com>
1bc5893 to
e6c0d1a
Compare
Owner
|
Thank @EricccTaiwan for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch improves input validation by ensuring that a letter input must be followed by a row number. If the user enters only a letter within the valid board range without a corresponding row number, an error message is displayed. This enhances clarity and prevents invalid moves, ensuring correct input handling.
Before
After