Merged
Conversation
This update adds validation to reject row number 0, which was previously allowed. While row numbers exceeding BOARD_SIZE were already handled, there was no explicit check for 0. An error is now triggered when 0 is entered. Co-authored-by: charliechiou <charlie910417@gmail.com>
Contributor
Author
I also wanted to ask whether it would be better to use a single error message for both row number |
Owner
|
Thank @EricccTaiwan for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update adds validation to reject row number
0, which was previously allowed. While row numbers exceedingBOARD_SIZEwere already handled, there was no explicit check for0. An error is now triggered when0is entered.Before
After