Skip to content

Read --verbose full's level without checking 'full' as a file (#1302) - #1304

Merged
jsiek merged 1 commit into
mainfrom
issue-1302-verbose-full
Nov 20, 2026
Merged

jsiek merged 1 commit into
mainfrom
issue-1302-verbose-full

Conversation

@jsiek

@jsiek jsiek commented Nov 20, 2026

Copy link
Copy Markdown
Owner

Closes #1302 (deduce.py --verbose full reads full as a file name)

$ python deduce.py --verbose full test/should-validate/fib.pf

Before: full was not found!, exit 1, and fib.pf isn't checked.
After: the full verbose trace, ending with test/should-validate/fib.pf is valid.

The --verbose branch of deduce.py's argument loop set the FULL level when the next argument was full, but didn't set already_processed_next, so full was also taken as a file. It now skips it, as --dir, --trace and -o do.

test-deduce.py --cli (the CLI sanity check) now also runs deduce.py --no-stdlib --verbose full theorem_true.pf and expects it to pass. test-deduce.py --cli and make static pass.

🤖 Generated with Claude Code

The `--verbose` branch set the FULL level when the next argument was
`full`, but didn't skip it, so `full` was also taken as a file to check
and deduce.py stopped with "full was not found!". The CLI sanity check
in test-deduce.py now also runs `--verbose full`.

Closes #1302

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T13:46:20.960699Z fc0cb8c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jsiek
jsiek merged commit 405e395 into main Nov 20, 2026
15 checks passed
@jsiek
jsiek deleted the issue-1302-verbose-full branch November 20, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deduce.py --verbose full reads 'full' as a file name

1 participant