Repository navigation
Read --verbose full's level without checking 'full' as a file (#1302) - #1304
Merged
Merged
Conversation
The `--verbose` branch set the FULL level when the next argument was `full`, but didn't skip it, so `full` was also taken as a file to check and deduce.py stopped with "full was not found!". The CLI sanity check in test-deduce.py now also runs `--verbose full`. Closes #1302 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1302 (
deduce.py --verbose fullreadsfullas a file name)Before:
full was not found!, exit 1, andfib.pfisn't checked.After: the full verbose trace, ending with
test/should-validate/fib.pf is valid.The
--verbosebranch ofdeduce.py's argument loop set the FULL level when the next argument wasfull, but didn't setalready_processed_next, sofullwas also taken as a file. It now skips it, as--dir,--traceand-odo.test-deduce.py --cli(the CLI sanity check) now also runsdeduce.py --no-stdlib --verbose full theorem_true.pfand expects it to pass.test-deduce.py --cliandmake staticpass.🤖 Generated with Claude Code