Clarify Codex worktree project resolution - #39
Open
jskoiz wants to merge 1 commit into
Open
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Owner
Author
|
Codex review pass: I did not find a blocking issue in this pass. Caveat: I reviewed the PR diff and reported check/validation metadata via gh only; I did not run the Swift test suite locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes AVM-42
Supersedes draft PR #28, which could not be marked ready for review because the GitHub connector ready-for-review mutation repeatedly failed with
GithubGraphQLAPIError: Field 'htmlUrl' doesn't exist on type 'PullRequest'and CLI fallback was unavailable due to invalidghauth.Summary
.claude/worktrees,.codex/worktrees, and.git/worktreesare marked worktree-likeValidation
CLANG_MODULE_CACHE_PATH="$PWD/.build/clang-module-cache" SWIFTPM_CACHE_PATH="$PWD/.build/swiftpm-cache" swift test --disable-sandbox --filter ProjectResolverTestsgit diff --checkFull
swift test --disable-sandboxwas attempted previously and reached the suite, but this sandbox blocks the live listener integration withlisten EPERMon127.0.0.1:39123.