UI redesign - #97
Merged
Merged
Conversation
…ce seams (File Repair + Assistant under the source rail, the Analysis tab stub) render as honest, inert "coming later" planks, motion honours prefers-reduced-motion from the committed S1 stylesheet, and serious+critical axe-zero is made structural. The empty second-ray goals get an honest home rather than a fake one: a new FutureSeams component (mounted in the workspace layout, under the source rail) renders File Repair and Assistant as short, single-affordance "coming later" rows that are inert-by-design — no redirect link to a stub route, no hidden affordance a keyboard or screen-reader user could tab to and then dead-end in — and the Analysis tab's S2 stub is consciously rendered as a passive support card, not a fake action (the D244 redirect-linking non-goal, honoured). The motion guard is a committed @media (prefers-reduced-motion: reduce) block in the @layer base, collapsing transition/animation/scroll motion to imperceptible under the OS preference. Serious+critical axe-zero is now a committed property: the e2e/accessibility.spec.ts sweep is extended so three additional landing states plus the workspace shell render zero serious/critical, and the new seams.spec.ts journey asserts the seams' copy + inertness, the Analysis seam, and the reduced-motion guard read numerically from computed style. One pre-existing latent harness race in the test set surfaced by S6's ⌘K journey and fixed here: the open-shortcut journey pressed Meta+K after only the server-rendered heading was visible, before the client hydrated the window keydown listener — CommandPaletteTrigger now sets a data-hydrated marker in the same commit that attaches the listener and the journey waits on it (flagged for the maintainer; a harness/test-set race, not a product defect). Gates: Python unchanged (4215 passed, coverage 91.79%, ruff/mypy/lint-imports clean); typecheck/lint clean; vitest 648 passed; Docker production build green; e2e-through-Docker 73/73 on a fresh down -v stack (66 M63/S2-S5 journeys + the S6 seams/reduced-motion + extended workspace-shell axe sweep, and the ⌘K journey now gated on the hydration marker). D247 + MASTER_SPEC Revision 1.92 recorded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.