V1.6 uir s7 viewer fixes - #98
Merged
Merged
Conversation
…de, bonds, samples, reset/expand)
…ix docstring typo
…fe, reorder window re-apply after setFrame
…in the Mol* mount
…ontrols Add @testing-library/user-event devDependency for the new interaction tests.
… expand overlay Review round 1: FullscreenViewer focused itself on open but never trapped Tab, leaving the background viewer-controls row keyboard-reachable behind the z-50 overlay. Reuses CommandPalette's event-capture trapTab idiom, generalized to a standard focusable selector since the overlay's contents are arbitrary. Also fixes an unmemoized onClose closure that re-ran FullscreenViewer's mount effect (re-stealing focus) on any unrelated re-render while expanded, and strengthens the bonds-toggle test to assert the prop reaches the mock mount, not just the badge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.