Skip to content

Fix JSON download interrupted by CAN mapping request#23

Merged
jsphuebner merged 6 commits into
jsphuebner:can-backendfrom
Modellfan:jsphuebner-can-backend
May 6, 2026
Merged

Fix JSON download interrupted by CAN mapping request#23
jsphuebner merged 6 commits into
jsphuebner:can-backendfrom
Modellfan:jsphuebner-can-backend

Conversation

@Modellfan

Copy link
Copy Markdown

Summary

  • defer initial CAN mapping load until parameter JSON has loaded successfully
  • reject CAN mapping reads while the CAN/JSON state machine is busy
  • restart JSON re-download correctly after an invalid cached JSON file
  • reset the segmented SDO toggle bit before starting a new JSON download

Testing

  • Tested on STM32 VCU hardware
  • platformio run succeeds

@Modellfan Modellfan mentioned this pull request May 6, 2026
@jsphuebner

jsphuebner commented May 6, 2026

Copy link
Copy Markdown
Owner

Just wondering how to handle the conflict between START and CLEAR. The start command is already out there in forms of inverter firmware 5.39.R. So issuing a clear command would in fact start the inverter.
We could just move clear to subIndex 6 to avoid this and mark 4 and 5 as reserved in the source

@Modellfan

Copy link
Copy Markdown
Author

jsphuebner/libopeninv@304ff90

Nothing more is what I did here.

@jsphuebner

Copy link
Copy Markdown
Owner

ah, lost that. Please PR (again?)

@Modellfan

Copy link
Copy Markdown
Author

Done. Is reopened. We should fix it here also again. I think I did it already somewhere. Can we merge this PR first, so I don't get to much chaos?

@Modellfan

Copy link
Copy Markdown
Author

I just commited it here.

@Modellfan

Copy link
Copy Markdown
Author

I don't get, how 8948c80
can be still part of this PR . You merged it already twice. Am I doing anything wrong?

@jsphuebner
jsphuebner merged commit f958dab into jsphuebner:can-backend May 6, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants