Skip to content

Port UI improvements from esp32-web-interface to esp8266-web-interface #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Port UI improvements from esp32-web-interface to esp8266-web-interface #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4f6d22
port UI improvements from esp32-web-interface copilot/apply-ui-change…
Copilot Apr 28, 2026
79410ba
use strict inequality for HTTP status comparison in inverter.js
Copilot Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions data/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,10 @@ <h2 id="large-modal-header"></h2>
<p>Communication problem between ESP and STM</p>
</div>

<div id="param-success-bar" class="param-success-bar">
<p id="param-success-bar-text"></p>
</div>

<!-- 'Add CAN Mapping' modal -->
<div id="can-mapping-modal-overlay" class="modal-overlay">
<div id="can-mapping-modal-container" class="can-mapping-modal-container">
Expand Down Expand Up @@ -91,7 +95,7 @@ <h3 class="underline">New CAN Mapping</h3>
<td>Set the ID of the CAN frame to send/receive</td>
</tr>
<tr>
<td>Offset</td>
<td>Position</td>
<td><input type="number" step="1" min="0" max="63" id="canpos"></td>
<td>Specify the position (offset) within the frame to place (transmit) or find (receive) this value</td>
</tr>
Expand All @@ -105,6 +109,11 @@ <h3 class="underline">New CAN Mapping</h3>
<td><input type="number" step="1" min="1" max="100" id="cangain"></td>
<td>Specify a gain to scale the value up or down</td>
</tr>
<tr>
<td>Offset</td>
<td><input type="number" step="1" min="-128" max="127" id="canoffset"></td>
<td>Specify an offset to add to the value</td>
</tr>
</table>
<button onclick="ui.canMapping();">
<!-- /icon-check-circle.png -->
Expand Down Expand Up @@ -151,17 +160,16 @@ <h3 class="underline">New CAN Mapping</h3>
<img class="navimg" src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABgAAAAYCAYAAADgdz34AAAACXBIWXMAAA7DAAAOwwHHb6hkAAAAGXRFWHRTb2Z0d2FyZQB3d3cuaW5rc2NhcGUub3Jnm+48GgAAAdRJREFUSInF1T1rlEEUBeBHYpHFJZDFQkhqsxELwdrPwlLtLP0g+heU+Ee0sLIViRYWJgGjEFBT6ppEsDGFNsYQLSUWc4d9s072fSOIB6Y598y5l7kzd/jHOFAT7+AyLqKLyeA3sIqnmMO3/SZuYRZb2KlZ30Pbamo+iZWKwXPMYAqHYnVxE/MV3QommphvxIY1nG5Q0Bmsx56NYUlalcpfYLyBecY4lmLvG4yWRLP6lQ+an8Az/MBXPCxU2sHH8LgzaN7Rb+jgsZzET3829wuODGjP6jd+V5E39Bs6iNzIBxiT+rQQ3L2CPseuVcm5IGcKGx6hJ92ejOOhf1fQ34rY4yq5FuRUYUMJF4Yk6EZstUpuB9muMR6RjjPr7xY07Yht7zfBSFScm3w/uEGMRXyrSjY5opyghyv2nmO7juhgkD0cxalIVsIvqbl1yNf8fZW8HlnnGxjUYTG8rlbJjvQ4dqTZshdeYXlI/Hx4bCqMmjwqPuHwXySojorbJcEo3oZgqVTBEHTwUs2wIw2wPK7XpdlSh3P6lX/W4E+YiCryfV+Qnv+09E7aOBbcYkX3uol5xqg0cnPjh61N6cyLx1L36Y/jkvTpT9v96X+QPv0nkeT/4DdxyppwcyvRBAAAAABJRU5ErkJggg=="><p class="navbar-text">SUPPORT</p></a>
</div>

<!-- spinner div -->
<div id="spinner-div" class="control">
<img style="vertical-align:middle" src="ajax-loader.gif"><p> refreshing...</p>
</div>

<!-- auto reload toggle -->
<div id="auto-reload-toggle-div" class="control small-screen-hide">
<label class="switch">
<input id="auto-reload-checkbox" type="checkbox" onclick="ui.setAutoReload(this.checked);"><span class="slider round"></span>
</label><p style="display: inline-block;">Auto reload</p>
</div>
<!-- spinner div -->
<div id="spinner-div" class="control">
<img style="vertical-align:middle" src="ajax-loader.gif"><p> refreshing...</p>
</div>
<!-- beta features toggle -->
<div id="beta-features-toggle-div" onclick="ui.toggleBetaFeaturesVisibility();" class="control small-screen-hide">
<label class="switch">
Expand Down Expand Up @@ -504,9 +512,10 @@ <h3 class="underline">Existing CAN Mappings</h3>
<th>Spot Value</th>
<th>Transmit or Receive</th>
<th>ID</th>
<th>Offset</th>
<th>Position</th>
<th>Length</th>
<th>Gain</th>
<th>Offset</th>
<th>Delete Mapping</th>
</tr>
</table>
Expand Down
53 changes: 36 additions & 17 deletions data/inverter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,23 @@ var paramsCache = {
{
if ( name in paramsCache.data ) {
if ( paramsCache.data[name].enums ) {
return paramsCache.data[name].enums[paramsCache.data[name].value];
} else {
return paramsCache.data[name].value;
}
if (paramsCache.data[name].enums[paramsCache.data[name].value])
{
return paramsCache.data[name].enums[paramsCache.data[name].value];
}
else
{
var active = [];
for (var key in paramsCache.data[name].enums)
{
if (paramsCache.data[name].value & key)
active.push(paramsCache.data[name].enums[key]);
}
return active.join('|');
}
} else {
return paramsCache.data[name].value;
}
}
}
return null;
Expand Down Expand Up @@ -79,6 +92,23 @@ var inverter = {
{
if (replyFunc) replyFunc(this.responseText);
}
xmlhttp.onreadystatechange = function() {
if (xmlhttp.readyState === XMLHttpRequest.DONE) {
console.log(req + ": " + xmlhttp.status);
if (xmlhttp.status !== 200) {
paramsCache.failedFetchCount += 1;
if ( paramsCache.failedFetchCount >= 2 && typeof ui !== 'undefined'){
ui.showCommunicationErrorBar();
}
}
else {
paramsCache.failedFetchCount = 0;
}
if ( paramsCache.failedFetchCount < 2 && typeof ui !== 'undefined') {
ui.hideCommunicationErrorBar();
}
}
}

if (repeat)
req += "&repeat=" + repeat;
Expand Down Expand Up @@ -106,18 +136,10 @@ var inverter = {
if (name == "version")
inverter.firmwareVersion = parseFloat(param.value);
}
paramsCache.failedFetchCount = 0;
}
catch(ex)
{
paramsCache.failedFetchCount += 1;
if ( paramsCache.failedFetchCount >= 2 ){
ui.showCommunicationErrorBar();
}
}
if ( paramsCache.failedFetchCount < 2 )
{
ui.hideCommunicationErrorBar();
console.error('Failed to parse params:', ex);
}
paramsCache.setData(params);
if (replyFunc) replyFunc(params);
Expand All @@ -144,10 +166,7 @@ var inverter = {
replyFunc(values);
};

if (inverter.firmwareVersion < 3.53 || items.length > 10)
inverter.sendCmd("get " + items.join(','), process, repeat);
else
inverter.sendCmd("stream " + repeat + " " + items.join(','), process);
inverter.sendCmd("stream " + repeat + " " + items.join(','), process);
},


Expand Down
19 changes: 19 additions & 0 deletions data/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,3 +656,22 @@ input:checked + .slider:before {
.communication-error-bar p {
text-align: center;
}

.param-success-bar {
display: none;
padding: 15px;
background-color: #4caf50;
color: white;
z-index: 100;
margin: 0 auto;
position: relative;
width: 30%;
top: 0px;
clear: left;
height: 20px;
border-radius: 0px 0px 20px 20px;
}

.param-success-bar p {
text-align: center;
}
Loading