Fix SDO response when removing can map entries#32
Merged
Conversation
Highlighted by an update to the canopen python library used by the openinverter_can_tool which more thoroughly handles poorly formed SDO responses. Tests: - Create and remove can map entries with "oic can add" and "oic can remove". - Verify CAN frames now decode correctly in Wireshark as: CANopen Default-SDO (rx): Initiate download request CANopen Default-SDO (tx): Initiate download response
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Highlighted by an update to the canopen python library used by the openinverter_can_tool which more thoroughly handles poorly formed SDO responses.
Tests:
CANopen Default-SDO (rx): Initiate download request
CANopen Default-SDO (tx): Initiate download response