Fix LIN checksum calculation#33
Merged
Merged
Conversation
There is a typo in the LIN checksum calculation that introduces a data dependency bug. According to Section 2.3.1.5 Checksum of the LIN Protocol Specification Revision 2.1 the checksum should check if the value is greater than or equal to 256 before subtracting 255. Add a set of unit tests with representative LIN data. Only TestSyntheticLinStatusResponse1() actually exhibits the bug. Tests: - Run new unit tests - Verify VWCoolantHeater simulator built with ESP32 and https://github.com/gicking/LIN_slave_portable_Arduino communicates data reliably with ZombieVerter VCU
Owner
|
Thanks Dave |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a typo in the LIN checksum calculation that introduces a data dependency bug. According to
Section 2.3.1.5 Checksum of the LIN Protocol
Specification Revision 2.1 the checksum should
check if the value is greater than or equal to 256 before subtracting 255.
Add a set of unit tests with representative LIN data. Only TestSyntheticLinStatusResponse1() actually
exhibits the bug.
Tests: