feat: parallelize FDSN provider station queries per box - #16
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…inberg34/reentry-seismo into parallelize-station-queries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
for provider in providersloop indownload_boxes()with aThreadPoolExecutorso all FDSN provider station queries for a given box fire concurrently_query_provideras a module-level worker function0.2.1and checks off the roadmap item in READMEBackground
For each download box, the old code queried each FDSN provider (EARTHSCOPE, SCEDC, etc.) sequentially with blocking
client.get_stations()HTTP calls. With N providers, the station-query phase costN × latencyper box — pure network idle time, since providers are completely independent servers with no data dependency between them.The new approach fires all queries concurrently, reducing per-box station-query time from
N × latencyto~latency. MassDownloader (which dominates total runtime) is untouched — it already parallelises internally and runs after all queries complete.Implementation notes
max_workers=max(1, len(clients))guards against the edge case where all providers fail to initialise andclientsis empty —ThreadPoolExecutor(max_workers=0)raisesValueErrorClientinstance initialised before the box loop, so there is no shared mutable state between threads{provider_name}_stations.xml), so no file contentionFDSNNoDataException→ skip silently, any other exception → log and skipTest plan
test_download_boxes_tolerates_get_stations_errors[nodata]—FDSNNoDataExceptionpathtest_download_boxes_tolerates_get_stations_errors[generic]— generic exception pathtest_download_boxes_tolerates_client_init_failure— emptyclientsdict edge case