add -Wno-narrowing to compiler flags#15
Merged
grosser merged 1 commit intojtoy:masterfrom Nov 19, 2018
Merged
Conversation
grosser
reviewed
Nov 19, 2018
Collaborator
|
what is the error you are seeing ... and on what platform ? @craig-day any opinion on this ? |
Contributor
Author
|
It seems this is caused by a regression in gcc 5 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65801) where it won't narrow signed integers to unsigned integers. Apparently this was fixed but it is unclear to me in which version. Output |
Collaborator
|
It is also necessary in the cld2 version of the gem. What was done there was to set the C++ version which also lets the compiler ignore these. BanjoInc#4 |
Collaborator
|
so what approach do you prefer ?
any idea how to make the tests run ?
…On Mon, Nov 19, 2018 at 11:27 AM Craig Day ***@***.***> wrote:
It is also necessary in the cld2 version of the gem. What was done there
was to set the C++ version which also lets the compiler ignore these.
BanjoInc#4 <BanjoInc#4>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#15 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AAAsZ54yI-mGQE5T64UvhCXIEksLcpTmks5uwwYvgaJpZM4YowVb>
.
|
Collaborator
|
0.8.0 is out ... idk if that will work ... if it does not, I'll just yank it and wait for anyone to fix the tests 🤷♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can't get this to compile otherwise.