Skip to content

Three concat lib tests fail on main after the recent merges #183

Description

@Domica

Problem

Three cargo test -p concat --lib tests fail on main. Every PR based on
main is blocked on them.

1. format::tests::zooming_in_reveals_the_fine_buckets_and_never_loses_a_peak

assertion `left == right` failed
  left: 2
 right: 1

The test expects one column to carry the spike; the waveform code counts
two after 2430478 perf(ui): waveforms at unity, scaled by the volume.
Either the test's expectation or the bucket assignment needs updating.

2. i18n::tests::every_shipped_locale_parses_names_itself_and_keys_off_the_inventory

de.json lacks ["Curvature", "Kaleidoscope", "Enhance", "Magnetic timeline",
               "Limited", "Colour range", "full range", ...]
(~200 keys, in every non-en locale)

English gained the strings from the effects expansion, Enhance, magnetic
timeline and Remote work; the other twelve locales have not caught up.
python3 scripts/locales.py --check would have caught this at merge time
but it is not in the CI gate.

3. panes::settings::listen_tests::a_missing_or_bad_half_gets_the_default

assertion `left == right` failed
  left: ("192.168.1.9:", 7420)
 right: ("192.168.1.9", 7420)

The listen-address parser keeps a trailing colon on a missing port; the
test expects the colon stripped.

Impact

Every PR based on main fails Engine tests and lints on one of these
three. Four of mine (#175, #176, #178, #179) are blocked. The fmt half
is fixed by #176; the three tests are not.

Reproduce

cd src
cargo test -p concat --lib zooming_in_reveals_the_fine_buckets
cargo test -p concat --lib every_shipped_locale_parses
cargo test -p concat --lib a_missing_or_bad_half_gets_the_default

All three fail on 041a233.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions