Skip to content

feat: PR 2/2 - a project format picker with ratio for phones #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Domica wants to merge 1 commit into from
Closed

feat: PR 2/2 - a project format picker with ratio for phones #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/crates/concat/src/studio.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,11 +160,15 @@ pub(crate) const EXPORT_CRF: [u8; 3] = [16, 20, 26];
pub(crate) const AUDIO_BPS: f32 = 192_000.0;

/// The frame sizes the launch screen offers, and what each label means.
pub const RESOLUTIONS: [(&str, u32, u32); 4] = [
pub const RESOLUTIONS: [(&str, u32, u32); 8] = [
("1080p", 1920, 1080),
("720p", 1280, 720),
("4K", 3840, 2160),
("Vertical", 1080, 1920),
("Vertical 9:16", 1080, 1920),
("Portrait 4:5", 1080, 1350),
("Square 1:1", 1080, 1080),
("Cinema 2:1", 2160, 1080),
("Widescreen 21:9", 2560, 1080),
];

/// The frame rates, as exact fractions. 29.97 is 30000/1001 and never
Expand Down
13 changes: 8 additions & 5 deletions src/crates/concat/ui/start.slint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { Theme } from "theme/theme.slint";
import { CopyChip } from "primitives/modal.slint";
import { Glyph, Icon } from "icons.slint";
import { SegmentedControl } from "primitives/segmented-control.slint";
import { Select } from "primitives/select.slint";
import { ThinScrollbar } from "primitives/scrollbar.slint";

// The launch screen.
Expand Down Expand Up @@ -635,13 +636,15 @@ export component StartScreen inherits Rectangle {
}

Field {
label: I18n.t("Resolution");
label: I18n.t("Format");
stacked: root.narrow;

// The control takes the row up to its natural width
// and the whole row on a phone, where four labels
// need every pixel there is.
SegmentedControl {
// A Select rather than the segmented strip the four
// 16:9 tiers used to fit: eight shapes, several with
// aspect words beside the number, and a strip would
// truncate every one. The trigger shows the current
// pick whole; the list holds them all.
Select {
width: Math.min(312px, parent.width);
options: root.resolutions;
current <=> root.res-index;
Expand Down
Loading