Skip to content

fix: resolve GitHub issues #184, #109, #139, #160, #100 - #187

Open
maubrickastuto wants to merge 1 commit into
jub0t:mainfrom
maubrickastuto:batch-1-fixes
Open

maubrickastuto wants to merge 1 commit into
jub0t:mainfrom
maubrickastuto:batch-1-fixes

Conversation

@maubrickastuto

Copy link
Copy Markdown
Contributor

Summary of Changes

This PR resolves 5 open GitHub issues across project settings, export dialog, inspector text editing, timeline seam handling, and Linux window metadata:

  1. 1440p support #184: Add 1440p (QHD / 2560×1440) Support

    • Added (2560, 1440) to OUTPUTS and ("1440p", 1440) to SIZES in studio.rs (preserving 1080p as the default at index 1).
    • Added 2560 × 1440 / 16:9 QHD options to project.slint and preview-pane.slint.
  2. The output resolution should match the project's format #109: Export Output Resolution Matches Project Aspect Ratio

    • Added dynamic resolution_options to ExportData so non-landscape projects (e.g. 9:16 vertical, 1:1 square) display correct scaled dimensions (1080 × 1920) instead of hardcoded 16:9 strings.
    • Initialized resolution and frame rate on ExportMsg::Open to match the active project.
  3. Text cards editing via "Inspector" panel bug scenarios #139: Fix Inspector Text Editing Typing Lag & Reversion Race Condition

    • Seeded local content property inside text-panel.slint to decouple keystroke rendering from round-trip state mutations.
    • Added commit_target tracking in Studio and flushed pending commits on timeline background click (on_band_selected) to prevent clearing selection before the commit timer fires.
  4. ghost element/artifact #160: Eliminate Ghost Transition Seams / Artifacts on Clip Cut & Delete

    • In RemoveClips, automatically sweep orphaned transition_in properties when the preceding contiguous clip is deleted.
    • In SplitClips, clamp or clear transition_in duration when splitting near or inside transition regions.
    • Filtered transition duration in publish_lanes to ensure seam controls only draw when a predecessor exists.
    • Reset transient drag/hover states on changed item in lanes.slint.
  5. Missing taskbar/dock icon when the app is running (shows generic gear) #100: Linux Dock / Taskbar Window Icon & Association

    • Configured with_name("concat", "concat") on Wayland/X11 window attributes.
    • Added icon: @image-url(...) to app.slint.
    • Added StartupWMClass=concat to the .desktop file generated in CI and flake.nix.

…jub0t#100

- feat(project): add 1440p (QHD / 2560x1440) support across launcher, monitor, and project dialog (jub0t#184)
- fix(export): match project aspect ratio and dynamic resolution options in export dialog (jub0t#109)
- fix(inspector): eliminate text typing lag, cursor jump, and click-outside reversion race (jub0t#139)
- fix(timeline): clean up orphaned transitions and ghost seam artifacts on split/delete (jub0t#160)
- fix(shell): configure Wayland app_id, StartupWMClass, and window icon for Linux dock/taskbar (jub0t#100)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant