Repository navigation
fix(timeline): the add-track menu's rows take their clicks - #296
Merged
Merged
Conversation
The tray's plus opened a menu whose Add track row flew a top-or-bottom submenu out beside it. A PopupWindow inside a PopupWindow draws where it likes, but the part hanging outside its parent never receives the pointer, so both rows could be seen and neither pressed (slint-ui/slint#7322). The menu is flat now - top and bottom as rows of the one popup, like every other menu here - so a press on either adds the lane it names. Signed-off-by: minecart551-prog <minecart551@gmail.com>
Owner
|
Can you append a screenshot of the new changed plus button dropdown? I'd like to see what this changes. |
Contributor
Author
just like this
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tray's plus opened a menu whose Add track row flew a top-or-bottom submenu out beside it. A PopupWindow inside a PopupWindow draws where it likes, but the part hanging outside its parent never receives the pointer, so both rows could be seen and neither pressed (slint-ui/slint#7322). The menu is flat now - top and bottom as rows of the one popup, like every other menu here - so a press on either adds the lane it names.