Review PR #14: Add file move/rename/copy tools

[Copilot]

Code review of PR #14 which adds move_file_code, rename_file_code, and copy_file_code tools to the VS Code MCP Server.

Review Summary

Assessment: Good PR with minor issues

Strengths

• Useful feature leveraging VS Code's WorkspaceEdit for automatic import path updates
• Consistent implementation following existing patterns
• Proper documentation updates

Issues Found

Error handling bug in copy_file_code (lines 396-399):

try {
    await vscode.workspace.fs.stat(targetUri);
    if (!overwrite) {
        throw new Error(`Target file ${targetPath} already exists...`);
    }
} catch (error) {
    // Target doesn't exist, which is fine  ← Swallows ALL errors
}

This silently swallows permission errors, network issues, etc.

Documentation mismatch: copy_file_code description claims "WorkspaceEdit API" but uses workspace.fs.readFile/writeFile

Directory limitation: Unlike move/rename, copy won't work for directories—should document or fix

Minor: Missing newline at EOF, no tests added

Original prompt

Can you review PR #14 and let me know how it looks? Thanks!

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.