refactor(executor): merge redundant #[cfg] branches for wait_with_timeout - #48
Merged
Merged
Conversation
…eout Windows and Unix implementations were byte-for-byte identical. Remove the platform-specific duplication and keep a single cross-platform function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observation
Platform audit found that
wait_with_timeoutinsrc/skill_runtime/executor.rshas two#[cfg]variants (Windows and Unix) that are byte-for-byte identical.Change
Collapse the duplicate
#[cfg(windows)]and#[cfg(unix)]implementations into a single cross-platform function. No behavioural change.Side effect
Eliminates the last platform-specific
#[cfg]duplication in the skill runtime, leaving only the legitimate Unix chmod indiscover.rs.