Repository navigation
fix(installer): roll back incomplete activation - #15
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ebf556b29
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| staging_directory="${runtimes_root}/.${runtime_version}.installing.$$" | ||
| lock_path="${data_root}/runtime.local.json" | ||
| lock_staging="${data_root}/.runtime.local.json.$$" | ||
| [ ! -d "$lock_path" ] || fail "Runtime lock path is a directory" |
There was a problem hiding this comment.
Register cleanup before rejecting a directory lock
When runtime.local.json is a directory, this new check calls fail after mktemp has created build_root but before the cleanup trap is registered. Every failed retry therefore leaves a safa-runtime-build.* directory in the temporary directory. Move this validation before mktemp, or install the cleanup trap before any validation that can exit.
Useful? React with 👍 / 👎.
Summary
Validation
swift test --parallel(214 tests, 33 suites)