fix(metrics)!: exclude the upper bound from Instant metric windows - #118
Merged
Merged
Conversation
The fourteen Instant-windowed queries filtered `between :from and :to`, but every caller passes an exclusive bound — toDate + 1 at midnight UTC. A record stamped on that instant was counted, and for the daily metrics bucketed into a calendar day outside the requested range, writing a snapshot with no coverage row. Half-open windows match every metric document and the convention GitHubPrReviewRepository already applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fourteen Instant-windowed queries filtered
between :from and :to, butevery caller passes an exclusive bound — toDate + 1 at midnight UTC. A record
stamped on that instant was counted, and for the daily metrics bucketed into a
calendar day outside the requested range, writing a snapshot with no coverage
row. Half-open windows match every metric document and the convention
GitHubPrReviewRepository already applied.