refactor(github): replace the flat service package with seven by con… - #122
Merged
Merged
Conversation
…cern github/service held sixteen classes with no structure. They now sit in client, repo, identity, commit, pullrequest, issue and scheduler. commit and pullrequest are deliberately symmetrical — collector, ingest service, stats enrichment service — so the two-phase pattern is visible in the tree rather than only in Javadoc. refreshReviews becomes public: the attribution backfill that calls it now lives in a different package, which is the use its Javadoc already described. No route changes: the sorted set of mapping literals hashes identically before and after. docs: update PROJECT_DESCRIPTION for the github package reorganisation Four class names changed, one service was split out, and the flat service package became seven. The document names each service, so it drifts the moment the code moves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cern
github/service held sixteen classes with no structure. They now sit in client,
repo, identity, commit, pullrequest, issue and scheduler.
commit and pullrequest are deliberately symmetrical — collector, ingest service,
stats enrichment service — so the two-phase pattern is visible in the tree rather
than only in Javadoc.
refreshReviews becomes public: the attribution backfill that calls it now lives
in a different package, which is the use its Javadoc already described.
No route changes: the sorted set of mapping literals hashes identically before
and after.
docs: update PROJECT_DESCRIPTION for the github package reorganisation
Four class names changed, one service was split out, and the flat service package
became seven. The document names each service, so it drifts the moment the code
moves.