Skip to content

Expose commonAncestor from Hook - #2

Open
brwarner wants to merge 2 commits into
juliankrispel:masterfrom
brwarner:expose-common-ancestor
Open

brwarner wants to merge 2 commits into
juliankrispel:masterfrom
brwarner:expose-common-ancestor

Conversation

@brwarner

Copy link
Copy Markdown

I wanted access to the commonAncestor property of the document's current selection.

Pretty simple change. Let me know if there are any issues or concerns (I haven't worked extensively with the selection API in Javascript).

@brwarner

Copy link
Copy Markdown
Author

Updated the documentation to match the feature. Also forked a version on npm with this feature which I can deprecate if you decide to merge this in.

https://www.npmjs.com/package/@brwarner/use-text-selection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant