Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## jg/newdo #184 +/- ##
============================================
+ Coverage 90.09% 95.54% +5.45%
============================================
Files 5 5
Lines 1474 1437 -37
============================================
+ Hits 1328 1373 +45
+ Misses 146 64 -82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joaquimg
reviewed
Aug 18, 2025
joaquimg
reviewed
Aug 18, 2025
andrewrosemberg
commented
Aug 18, 2025
Comment on lines
+1501
to
+1520
| @test_throws MOI.UnsupportedConstraint @constraint( | ||
| model, | ||
| con, | ||
| [p * p, x * (x - 1), p] in MOI.PositiveSemidefiniteConeTriangle(2) | ||
| ) | ||
| @test_throws MOI.UnsupportedConstraint @constraint( | ||
| model, | ||
| con, | ||
| [x * x, (x - 1), p] in MOI.PositiveSemidefiniteConeTriangle(2) | ||
| ) | ||
| @test_throws MOI.UnsupportedConstraint @constraint( | ||
| model, | ||
| con, | ||
| [p, (x - 1), x * x] in MOI.PositiveSemidefiniteConeTriangle(2) | ||
| ) | ||
| @test_throws MOI.UnsupportedConstraint @constraint( | ||
| model, | ||
| con, | ||
| [x, p * (x - 1), x * x] in MOI.PositiveSemidefiniteConeTriangle(2) | ||
| ) |
Collaborator
Author
There was a problem hiding this comment.
Codecov is saying that this line is not hit:
https://app.codecov.io/gh/jump-dev/ParametricOptInterface.jl/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jump-dev#0f1f4f0ce11f1dcba9e19c7e66fade02-R988
But running locally, the following tests hit the missed lines.
joaquimg
added a commit
that referenced
this pull request
Aug 19, 2025
* temp * fix and format * remove func * Adds support for VectorQuadraticFunction (#179) * add ParametricVectorQuadraticFunction * use at_variable and remove unecessary calls * start addressing variable coefficients * update tests * fix bugs * fix bug * update add constraint * update test * update jump test * fix test * rm update * update add_constraint * attemp replace * update functions * update * update * working first set * update tol * update tol * finish * change tests names * Apply suggestions from code review --------- Co-authored-by: Joaquim <joaquimdgarcia@gmail.com> * format * fix NLP block * continue fix NLP block * Fix TODOs New API (#182) * fix VariablePrimalStart * add get VariablePrimalStart * fix "is_valid" * fix ambiguity * format --------- Co-authored-by: joaquimg <joaquimdgarcia@gmail.com> * Ar/newdo (#183) * fix VariablePrimalStart * add get VariablePrimalStart * fix "is_valid" * fix ambiguity * format * add more vector tests --------- Co-authored-by: Andrew <arosemberg3@gatech.edu> * add tests and vec fucntionfix * format * Fix key vector quadratic and add tests (#184) * fix key vector quadratic * add new tests and fix affine cache * format * test constraint name set and get * add no parameter problem * fix test name * fix comment * force has_parameter and !_is_vector_affine * update coverage * remove useless function * update tests coverage * format and rm useless functions * improve tests to force coverage improvement * fix typo * Improve coverage (#187) * update tests and coverage * update tests * update tests * add copy to test * fix typo * format * fix typo * Improve coverage 2.0 (#188) * improve coverage 2.0 * format * fix typo * bump version --------- Co-authored-by: Andrew Rosemberg <andrewrosemberg@gmail.com> Co-authored-by: Andrew <arosemberg3@gatech.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.