Skip to content

Changed object names for aMISP complience and unification of credit cards#36

Open
MoonsBeast wants to merge 2 commits intojunquera:developfrom
MoonsBeast:Feature_MISP_Taxonomies
Open

Changed object names for aMISP complience and unification of credit cards#36
MoonsBeast wants to merge 2 commits intojunquera:developfrom
MoonsBeast:Feature_MISP_Taxonomies

Conversation

@MoonsBeast
Copy link
Copy Markdown
Contributor

@MoonsBeast MoonsBeast commented Jul 11, 2025

Renamed objects and their related variables and parameteters to be MISP compliance.

MISP:

  • Base64
  • Phone-number
  • Bitcoin-address
  • Twitter
  • Telegram
  • WhatsApp
  • SHA1
  • SHA256
  • Onion-address

The rest of classes and params is modified in order of uniformity.

Fixed credit card duplicated search and parameters by merging the processes.

Added modified params to README.

Rodrigo Calero added 2 commits July 10, 2025 10:01
Renamed objets and their related variables and parameteters to be MISP compliance.

Fixed credit card duplicated search and parameters by merging the processes.
@CarlosLannister CarlosLannister requested a review from Copilot July 11, 2025 09:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames various Item subclasses and their related parameters for MISP compliance, consolidates credit card detection logic to eliminate duplicates, and updates the README with the new parameter names.

  • Renamed Item subclasses (e.g., PhonePhoneNumber, BTC_WalletBitcoinAddress) and updated all corresponding flags and usages.
  • Merged generic and vendor-specific credit card regexes into a single extraction step to avoid duplicate detections.
  • Updated README to reflect the new flag names for each extractor.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
restalker/restalker.py Renamed classes, flags, and variables for compliance; unified CC extraction; minor URL-extraction tweaks.
restalker/init.py Updated imports to match renamed classes.
README.md Updated usage examples and parameter flags to match new names.
Comments suppressed due to low confidence (3)

restalker/restalker.py:658

  • Avoid using a mutable default argument for keywords. Consider changing the default to None and then inside the constructor set self.keywords = keywords or [] to prevent unexpected shared state.
class reStalker:

restalker/restalker.py:974

  • Add unit tests covering the combined credit card extraction logic to verify both specific and generic patterns are correctly merged and deduplicated, ensuring no valid cards are missed or duplicated.
            card_numbers = set(card_numbers + generic_card_numbers)

README.md:92

  • The zeronet_ctxt flag (used for context-based ZeroNet element extraction) is not documented here; consider adding a note or example to explain its purpose and how it differs from zeronet_address.
- **ZeroNet** URLs `(zeronet_address=True)`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants