Changed object names for aMISP complience and unification of credit cards#36
Open
MoonsBeast wants to merge 2 commits intojunquera:developfrom
Open
Changed object names for aMISP complience and unification of credit cards#36MoonsBeast wants to merge 2 commits intojunquera:developfrom
MoonsBeast wants to merge 2 commits intojunquera:developfrom
Conversation
added 2 commits
July 10, 2025 10:01
Renamed objets and their related variables and parameteters to be MISP compliance. Fixed credit card duplicated search and parameters by merging the processes.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames various Item subclasses and their related parameters for MISP compliance, consolidates credit card detection logic to eliminate duplicates, and updates the README with the new parameter names.
- Renamed Item subclasses (e.g.,
Phone→PhoneNumber,BTC_Wallet→BitcoinAddress) and updated all corresponding flags and usages. - Merged generic and vendor-specific credit card regexes into a single extraction step to avoid duplicate detections.
- Updated README to reflect the new flag names for each extractor.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| restalker/restalker.py | Renamed classes, flags, and variables for compliance; unified CC extraction; minor URL-extraction tweaks. |
| restalker/init.py | Updated imports to match renamed classes. |
| README.md | Updated usage examples and parameter flags to match new names. |
Comments suppressed due to low confidence (3)
restalker/restalker.py:658
- Avoid using a mutable default argument for
keywords. Consider changing the default toNoneand then inside the constructor setself.keywords = keywords or []to prevent unexpected shared state.
class reStalker:
restalker/restalker.py:974
- Add unit tests covering the combined credit card extraction logic to verify both specific and generic patterns are correctly merged and deduplicated, ensuring no valid cards are missed or duplicated.
card_numbers = set(card_numbers + generic_card_numbers)
README.md:92
- The
zeronet_ctxtflag (used for context-based ZeroNet element extraction) is not documented here; consider adding a note or example to explain its purpose and how it differs fromzeronet_address.
- **ZeroNet** URLs `(zeronet_address=True)`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed objects and their related variables and parameteters to be MISP compliance.
MISP:
The rest of classes and params is modified in order of uniformity.
Fixed credit card duplicated search and parameters by merging the processes.
Added modified params to README.