Skip to content

feat(breeze_buddy): normalize lead_call_tracker outcomes to UPPERCASE #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MonishJuspay wants to merge 1 commit into
base: release
Choose a base branch
from
Open

feat(breeze_buddy): normalize lead_call_tracker outcomes to UPPERCASE #739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions app/database/migrations/026_normalize_outcomes_to_uppercase.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
-- Migration 026: Normalize lead_call_tracker.outcome values to UPPERCASE.
-- All Clairvoyance code uses UPPERCASE outcome literals; this backfills any
-- historical rows where a bypass path may have written lowercase.
-- Going forward, the DB query layer enforces UPPER() at INSERT/UPDATE time.

BEGIN;

UPDATE lead_call_tracker
SET outcome = UPPER(outcome)
WHERE outcome IS NOT NULL
AND outcome <> UPPER(outcome);

COMMIT;
4 changes: 2 additions & 2 deletions app/database/queries/breeze_buddy/lead_call_tracker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def insert_lead_call_tracker_query(
call_id,
outbound_number_id,
call_direction.value,
outcome,
outcome.upper() if outcome else None,
datetime.now(),
datetime.now(),
]
Expand Down Expand Up @@ -330,7 +330,7 @@ def update_lead_call_completion_details_query(
set_clauses.append(f'"status" = ${len(values)}')

if outcome is not None:
values.append(outcome)
values.append(outcome.upper())
set_clauses.append(f'"outcome" = ${len(values)}')

if meta_data is not None:
Expand Down
Loading