Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BZ-2950: fix(breeze-buddy): suppress harmless Pipecat WS close error on client-initiated disconnect #759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
BZ-2950: fix(breeze-buddy): suppress harmless Pipecat WS close error on client-initiated disconnect #759
Changes from all commits
8e9eebdFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major | ⚡ Quick win
Import and use constants from
pipecat_log_filter.pyto avoid string duplication.The error message substrings are hardcoded here, but
pipecat_log_filter.pydefinesPIPECAT_WS_CLOSE_MARKERandSTARLETTE_WS_CLOSE_ERRORconstants with identical values. Importing these constants ensures a single source of truth and prevents drift if the error messages need updating.♻️ Refactor to use shared constants
At the top of the file, add the import:
Then update the filter condition:
if ( logger_name.startswith("pipecat") - and "exception while closing the websocket" in message - and 'Cannot call "send" once a close message has been sent' in message + and PIPECAT_WS_CLOSE_MARKER in message + and STARLETTE_WS_CLOSE_ERROR in message ): return False🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.