ref: optimized the payment_experience object - #83
Open
Pradeep-kumar1202 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Before : Every time the SDK wanted the experiences for one payment method, it re-scanned the entire sdk-config list from scratch — filter the methods, flatten their sub-types, filter again, flatten the rules, then dedup. The one real caller does this inside the /client response parser.
After : The config is walked once, producing a dictionary from "payment_method:payment_method_type" to its experience list. Answering the question for a method becomes a single O(1) dictionary lookup. The scan cost is paid once per parsed sdk-config instead of once per payment method
sdk-configscan with a build-once payment-experience indexHow did you test it?
Impact on Mobile and Web Repositories
Outline steps taken to ensure compatibility with consuming repositories:
Checklist