fix: superposition config race condition - #84
Open
Shivam25092001 wants to merge 1 commit into
Open
Conversation
16 tasks
manideepk90
approved these changes
Aug 7, 2026
manideepk90
reviewed
Aug 7, 2026
| @@ -11,6 +11,8 @@ external cacReader: JSON.t => Nullable.t<configurationService> = "CacReader" | |||
| let service = ref(None) | |||
Contributor
There was a problem hiding this comment.
can we use the useRef instead of the ref in the useConfigurationService?
Contributor
Author
There was a problem hiding this comment.
This is anyways changed in the latest of 'main' so didn't add much changing it here.
Do you see any other benefits here for useRef, rather than tying this variable to react ?
Contributor
There was a problem hiding this comment.
If the value doesn't need to trigger re-renders and isn't component-specific, the current approach seems reasonable.
Contributor
There was a problem hiding this comment.
If we don't need to scope it to the component, I think the current approach is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Refer: juspay/hyperswitch-client-core#552
How did you test it?
Impact on Mobile and Web Repositories
Outline steps taken to ensure compatibility with consuming repositories:
Checklist