BZ-1810: fix: return 204 instead of 404 when prompt not found#39
Merged
murdore merged 1 commit intoApr 22, 2026
Merged
Conversation
rab1prasad
force-pushed
the
BZ-2440-langfuse-return-204-instead-of-404-when-prompt-not-found
branch
from
9c18e3d to
5ac3f60
Compare
itz-PrathamMittal
approved these changes
Apr 21, 2026
…1 for /prompt
- The GET /api/public/v2/prompts/:name endpoint threw
LangfuseNotFoundError (HTTP 404) when the prompt did not exist,
which produced 4xx alert noise on ALB for benign client lookups.
Return 204 No Content instead so clients can handle the absence
without triggering infra alerts.
- GET /api/public/v2/prompts/<name> now responds 200 with
{ accessDenied: true, message, prompt: null } on UnauthorizedError
or ForbiddenError to quiet ALB 4xx alerts. Other errors still rethrow.
rab1prasad
force-pushed
the
BZ-2440-langfuse-return-204-instead-of-404-when-prompt-not-found
branch
from
5ac3f60 to
b02082d
Compare
manas-narra
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public prompt lookups generate high ALB 4xx volume from benign client
behavior (unknown prompt names, invalid/rotated API keys), which pages
on the shared CloudWatch 4xx alarm. Narrowing the alarm at the infra
layer is not feasible short-term, so we suppress the noise at the
application layer.
The GET /api/public/v2/prompts/:name endpoint threw
LangfuseNotFoundError (HTTP 404) when the prompt did not exist,
which produced 4xx alert noise on ALB for benign client lookups.
Return 204 No Content instead so clients can handle the absence
without triggering infra alerts.
GET /api/public/v2/prompts/ now responds 200 with
{ accessDenied: true, message, prompt: null } on UnauthorizedError
or ForbiddenError to quiet ALB 4xx alerts. Other errors still rethrow.
dev proof
