Repository navigation
fix: fail closed on empty or incomplete twin inventory - #26
Merged
Merged
Conversation
Distinguish complete inventory (ALLOW via no-blast-radius when the package is absent) from empty/incomplete twins (UNKNOWN / incomplete-inventory, non-zero exit). Set inventory_complete at ingest when SBOMs cover all running workloads. Release dogfood drops Grype || true and asserts policy decision JSON. Co-authored-by: Andrey Lesnikov <justrunme@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fail closed when the twin cannot prove a package is absent.
no-blast-radiusALLOW now requiresinventory_complete=true. The flag is set on ingest only when every running workload resolves to an artifact with a real SBOM package inventory; empty or stub-only twins stay incomplete and yieldUNKNOWN/incomplete-inventory(exit 1).|| true, and the dogfood step asserts the policy decision for every CVE (fails on BLOCK/QUARANTINE/UNKNOWN), not just CVE counts.Tests: empty twin + CVE is not ALLOW, complete twin without the package is ALLOW, inventory completeness on ingest, dogfood gate rejects BLOCK/UNKNOWN, release workflow has no masked Grype.