Repository navigation
Buddy 1.1.2: the update helper really starts on every PC - #5
Merged
Merged
Conversation
…HED_PROCESS (1.1.2) Seen live on a real PC: Buddy downloaded and self-tested 1.1.1, started the helper and quit - but a PowerShell started with DETACHED_PROCESS never ran, so nothing was swapped and Buddy stayed closed. A side-by-side test on the same PC: DETACHED -> never ran, CREATE_NO_WINDOW -> ran at once. - launch_hidden(): CREATE_NO_WINDOW + new process group, tries to break away from the job first - test runs a real hidden PowerShell through launch_hidden and waits for its mark - island shows download progress (25 percent steps)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause of a live failure: the swap helper was started with DETACHED_PROCESS and on this PC such a console process never runs, so Buddy quit for an update that never came. Side-by-side on the same PC: DETACHED never ran, CREATE_NO_WINDOW ran at once. Now launch_hidden() uses a hidden console and leaves the job object if it can. New test goes through the real launch path (the old tests ran the helper directly, which is why they missed it). The island also shows download progress.