Repository navigation
site: 24px hit area for mock dialog buttons on phones - #9
Merged
Merged
Conversation
The demo stage is drawn at 800px and scaled to fit, so at 390px the Notepad Save/Don't Save/Cancel and Buddy Yes/No buttons rendered ~11-13px tall. fitStage() now sets --inv-scale and a ::after on .win-btn/.cbtn grows the click area to >=24 rendered px without changing the look. Measured at 390px: hit boxes 25-39 x 24.5-25 px (was 20-38 x 12-13); 1280px unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queue item buddy site A5/A6. The demo stage is drawn at 800px and scaled; at 390px the mock dialog buttons rendered ~11-13px tall. fitStage() sets --inv-scale; a ::after on .win-btn/.cbtn grows the click area to at least 24 rendered px with no visual change. Playwright at 390px: hit boxes 25-39 x 24.5-25 px (was 20-38 x 12-13). At 1280px unchanged (61-97 x 31.5-34).