Repository navigation
Use kaala instead of window for vaara-conditioned anga-touch checks - #35
Merged
Merged
Conversation
`window` reinvented what `kaala` (already an existing timing field,
resolved via DailyPanchaanga.get_interval) already does -- "sunrise"
duplicated get_interval's own zero-width-instant special case, and
"sunrise_to_purvaahna"/"sunrise_to_sunset" duplicated its generic
day_length_based_periods.puurvaahna/dinamaana lookup. Switching to kaala
reuses that existing machinery instead of hand-rolling it, and is open to
any other named kaala for free.
Also sets kaala explicitly (rather than relying on the implicit dinamaana
default) on the two older aGgArakI~caturthI rules, for consistent,
non-misleading auto-generated description text -- their kaala had
previously been left unset entirely, so the generic description template
was filling in its own default label ("Sūryōdayaḥ"/sunrise), which never
matched the anga-touch window (dinamaana) actually being checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion data change for the
jyotishaPR of the same title.window = "sunrise"withkaala = "sunrise"onvAjapEyaphala-snAna-yOgaHandjayantI~aSTamIwindow = "sunrise_to_purvaahna"withkaala = "puurvaahna"onkRSNAGgAraka-caturdazI-puNyakAlaH_or_yamatarpaNamandpizAcamOcanamkaala = "dinamaana"tobharaNI-yamArcanAand the two olderaGgArakI~caturthIrules (previously relied on an implicit default, which left their auto-generated description text showing a mismatched "Sūryōdayaḥ"/sunrise label)🤖 Generated with Claude Code
Generated by Claude Code