Use configured install users for controller components#7594
Open
twz123 wants to merge 1 commit into
Open
Conversation
ncopa
previously approved these changes
May 11, 2026
Contributor
|
This pull request has merge conflicts that need to be resolved. |
Although the install command creates custom system users during installation, the controller components still use hard-coded default user names. Use the users specified in the config's install section for the generated certificates and kubeconfigs, as well as for executing the supervised processes. The config naming is unfortunate because it is now used during both installation and execution. However, if the users are not used for execution creating them during installation is futile. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
twz123
force-pushed
the
use-install-users-for-execution
branch
from
a123210 to
2d906de
Compare
Contributor
|
This pull request has merge conflicts that need to be resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Although the install command creates custom system users during installation, the controller components still use hard-coded default user names.
Use the users specified in the config's install section for the generated certificates and kubeconfigs, as well as for executing the supervised processes. The config naming is unfortunate because it is now used during both installation and execution. However, if the users are not used for execution creating them during installation is futile.
Fixes:
spec.installConfig.usersand users used to run components #4265Type of change
How Has This Been Tested?
Checklist