Some log tweaks#7663
Open
twz123 wants to merge 2 commits into
Open
Conversation
Some processes prefer to re-raise SIGTERM instead of exiting with a zero exit code. In that case, k0s cannot determine whether the process had a clean shutdown or if it even had a proper signal handler to begin with. Downgrade this case from an error to a warning and make the log message reflect that the process terminated with SIGTERM instead of exiting cleanly. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
When the controller lease counter was stopped, an error was logged about losing the controller lease. This is actually the expected behavior. Downgrade that log to info. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
jnummelin
approved these changes
May 26, 2026
Contributor
|
This pull request has merge conflicts that need to be resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some processes prefer to re-raise SIGTERM instead of exiting with a zero exit code. In that case, k0s cannot determine whether the process had a clean shutdown or if it even had a proper signal handler to begin with. Downgrade this case from an error to a warning in supervisor and make the log message reflect that the process terminated with SIGTERM instead of exiting cleanly.
When the controller lease counter was stopped during component shutdown, an error was logged about losing the controller lease. This is actually the expected behavior. Downgrade that log to info.
Type of change
How Has This Been Tested?
Checklist