Skip to content

Keep the old names when generating admin kubeconfigs#7688

Merged
twz123 merged 1 commit into
k0sproject:mainfrom
twz123:old-kubeconfig-names
May 26, 2026
Merged

Keep the old names when generating admin kubeconfigs#7688
twz123 merged 1 commit into
k0sproject:mainfrom
twz123:old-kubeconfig-names

Conversation

@twz123

@twz123 twz123 commented May 26, 2026

Copy link
Copy Markdown
Member

Description

Of course, the initial assumption that nothing should rely on the actual names of the cluster, auth info and context in the admin kubeconfig was wrong: k0sctl relies on them and will panic if the admin kubeconfig has a different structure.

Use the old names again for them. Those aren't that important anyways, and it doesn't make sense to introduce a breaking change for this.

See:

Fixes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 added bug Something isn't working area/cli labels May 26, 2026
@twz123 twz123 added this to the 1.36 milestone May 26, 2026
Of course, the initial assumption that nothing should rely on the actual
names of the cluster, auth info and context in the admin kubeconfig was
wrong: k0sctl relies on them and will panic if the admin kubeconfig has
a different structure.

Use the old names again for them. Those aren't that important anyways, and
it doesn't make sense to introduce a breaking change for this.

Fixes: aa35c70 ("Build admin kubeconfig directly from PKI files")
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 force-pushed the old-kubeconfig-names branch from d0906a3 to 66d5017 Compare May 26, 2026 08:34
@twz123 twz123 marked this pull request as ready for review May 26, 2026 10:34
@twz123 twz123 requested review from a team as code owners May 26, 2026 10:34
@twz123 twz123 requested review from kke and makhov May 26, 2026 10:34
@twz123 twz123 merged commit 061eb25 into k0sproject:main May 26, 2026
207 of 208 checks passed
@twz123 twz123 deleted the old-kubeconfig-names branch May 26, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cli bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants