Keep the old names when generating admin kubeconfigs#7688
Merged
Conversation
Of course, the initial assumption that nothing should rely on the actual names of the cluster, auth info and context in the admin kubeconfig was wrong: k0sctl relies on them and will panic if the admin kubeconfig has a different structure. Use the old names again for them. Those aren't that important anyways, and it doesn't make sense to introduce a breaking change for this. Fixes: aa35c70 ("Build admin kubeconfig directly from PKI files") Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
d0906a3 to
66d5017
Compare
jnummelin
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Of course, the initial assumption that nothing should rely on the actual names of the cluster, auth info and context in the admin kubeconfig was wrong: k0sctl relies on them and will panic if the admin kubeconfig has a different structure.
Use the old names again for them. Those aren't that important anyways, and it doesn't make sense to introduce a breaking change for this.
See:
Fixes:
Type of change
How Has This Been Tested?
Checklist